imay commented on a change in pull request #368: Add a frontend interface for
committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238515652
##########
File path: gensrc/thrift/FrontendService.thrift
##########
@@ -510,6 +510,7 @@ struct TLoadTxnCommitRequest {
7: required i64 txnId
8: required bool sync
9: optional list<Types.TTabletCommitInfo> commitInfos
+ 10: optional string extra
Review comment:
It's a bad idea to use string, use another thrift struct to define your need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
