morningman commented on a change in pull request #368: Add a frontend interface
for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238518222
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -229,8 +265,34 @@ public void readFields(DataInput in) throws IOException {
// TODO(ml)
}
- abstract RoutineLoadTask createTask(RoutineLoadTaskInfo
routineLoadTaskInfo, long beId);
+ public void removeNeedSchedulerTask(RoutineLoadTaskInfo
routineLoadTaskInfo) {
+ writeLock();
+ try {
+ needSchedulerTaskInfoList.remove(routineLoadTaskInfo);
+ } finally {
+ writeUnlock();
+ }
+ }
+
+ abstract void updateProgress(String progress);
+
+ @Nullable
+ public RoutineLoadJob getJobByTaskId(String taskId) {
Review comment:
I think this method should be called: containsTask() and return boolean?
It is so weird to call a RoutineLoadJob. getJobByTaskId() and return null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
