morningman commented on a change in pull request #368: Add a frontend interface
for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238518396
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -241,4 +303,99 @@ private void checkStateTransform(RoutineLoadJob.JobState
currentState, RoutineLo
}
}
+ private void loadTxnCommit(TLoadTxnCommitRequest request) throws
TException {
+ FrontendServiceImpl frontendService = new
FrontendServiceImpl(ExecuteEnv.getInstance());
+ frontendService.loadTxnCommit(request);
Review comment:
Are you sure to call the method of FrontendServiceImpl in RountineLoadJob?
I think you misunderstanding the hierarchical design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
