morningman commented on a change in pull request #368: Add a frontend interface 
for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238514441
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
 ##########
 @@ -666,6 +672,12 @@ private boolean loadTxnCommitImpl(TLoadTxnCommitRequest 
request) throws UserExce
             throw new UserException("unknown database, database=" + dbName);
         }
 
+        // update extra in transaction state
+        if (!Strings.isNullOrEmpty(request.getExtra())) {
 
 Review comment:
   use request.isSetExtra() to check if the member is set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to