morningman commented on a change in pull request #368: Add a frontend interface
for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r239677359
##########
File path:
fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
##########
@@ -646,6 +676,8 @@ public void finishTransaction(long transactionId,
Set<Long> errorReplicaIds) {
transactionState.setFinishTime(System.currentTimeMillis());
transactionState.setTransactionStatus(TransactionStatus.VISIBLE);
unprotectUpsertTransactionState(transactionState);
+ } catch (TransactionException e) {
+ LOG.warn("failed to change txn state to visible");
Review comment:
This kind of log is meaningless, no one knows which transaction is visible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
