imay commented on a change in pull request #697: Optimize decimal by
introducing decimal_v2 (#695)
URL: https://github.com/apache/incubator-doris/pull/697#discussion_r262917067
##########
File path: fe/src/main/cup/sql_parser.cup
##########
@@ -3106,11 +3106,11 @@ type ::=
| KW_CHAR
{: RESULT = ScalarType.createCharType(-1); :}
| KW_DECIMAL LPAREN INTEGER_LITERAL:precision RPAREN
- {: RESULT = ScalarType.createDecimalType(precision.intValue()); :}
+ {: RESULT = ScalarType.createDecimal_V2Type(precision.intValue()); :}
| KW_DECIMAL LPAREN INTEGER_LITERAL:precision COMMA INTEGER_LITERAL:scale
RPAREN
- {: RESULT = ScalarType.createDecimalType(precision.intValue(),
scale.intValue()); :}
+ {: RESULT = ScalarType.createDecimal_V2Type(precision.intValue(),
scale.intValue()); :}
Review comment:
in Java, please not use underline in function name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
