imay commented on a change in pull request #697: Optimize decimal by
introducing decimal_v2 (#695)
URL: https://github.com/apache/incubator-doris/pull/697#discussion_r263638462
##########
File path: be/src/exec/olap_rewrite_node.cpp
##########
@@ -179,6 +183,24 @@ bool OlapRewriteNode::copy_one_row(TupleRow* src_row,
Tuple* tuple,
}
break;
}
+ case TPrimitiveType::DECIMALV2: {
+ DecimalV2Value* dec_val = (DecimalV2Value*)src_value;
+ DecimalV2Value* dst_val =
(DecimalV2Value*)tuple->get_slot(slot_desc->tuple_offset());
+ if (dec_val->scale() > column_type.scale) {
Review comment:
can you can `scale` from the DecimalV2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
