imay commented on a change in pull request #697: Optimize decimal by
introducing decimal_v2 (#695)
URL: https://github.com/apache/incubator-doris/pull/697#discussion_r262962652
##########
File path: be/src/runtime/raw_value.h
##########
@@ -406,6 +420,10 @@ inline uint32_t RawValue::zlib_crc32(const void* v, const
TypeDescriptor& type,
seed = HashUtil::zlib_crc_hash(&int_val, sizeof(int_val), seed);
return HashUtil::zlib_crc_hash(&frac_val, sizeof(frac_val), seed);
}
+
+ case TYPE_DECIMAL_V2: {
Review comment:
you should keep this same with TYPE_DECIMAL, because we use this to
distribute data
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
