EmmyMiao87 commented on a change in pull request #754: Add persist operations
for routine load job
URL: https://github.com/apache/incubator-doris/pull/754#discussion_r265538840
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java
##########
@@ -55,26 +61,28 @@
public class KafkaRoutineLoadJob extends RoutineLoadJob {
private static final Logger LOG =
LogManager.getLogger(KafkaRoutineLoadJob.class);
- private static final String FE_GROUP_ID = "fe_fetch_partitions";
- private static final int FETCH_PARTITIONS_TIMEOUT = 10;
+ private static final int FETCH_PARTITIONS_TIMEOUT_SECOND = 10;
private String brokerList;
private String topic;
// optional, user want to load partitions.
- private List<Integer> customKafkaPartitions;
+ private List<Integer> customKafkaPartitions = Lists.newArrayList();
// current kafka partitions is the actually partition which will be fetched
- private List<Integer> currentKafkaPartitions;
+ private List<Integer> currentKafkaPartitions = Lists.newArrayList();
// this is the kafka consumer which is used to fetch the number of
partitions
private KafkaConsumer consumer;
- public KafkaRoutineLoadJob(String name, long dbId, long tableId, String
brokerList, String topic) {
- super(name, dbId, tableId, LoadDataSourceType.KAFKA);
+ public KafkaRoutineLoadJob() {
+ // for serialization, id is dummy
+ super(-1, LoadDataSourceType.KAFKA);
+ }
+
+ public KafkaRoutineLoadJob(Long id, String name, long dbId, long tableId,
String brokerList, String topic) {
Review comment:
Maybe id can be initialized by itself
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
