EmmyMiao87 commented on a change in pull request #754: Add persist operations
for routine load job
URL: https://github.com/apache/incubator-doris/pull/754#discussion_r265533704
##########
File path:
fe/src/main/java/org/apache/doris/analysis/CreateRoutineLoadStmt.java
##########
@@ -221,65 +219,62 @@ private void checkLoadProperties(Analyzer analyzer)
throws AnalysisException {
throw new AnalysisException("repeat setting of column
separator");
}
columnSeparator = (ColumnSeparator) parseNode;
- columnSeparator.analyze(analyzer);
- } else if (parseNode instanceof LoadColumnsInfo) {
+ columnSeparator.analyze(null);
+ } else if (parseNode instanceof ImportColumnsStmt) {
// check columns info
- if (columnsInfo != null) {
+ if (importColumnsStmt != null) {
throw new AnalysisException("repeat setting of columns
info");
}
- columnsInfo = (LoadColumnsInfo) parseNode;
- columnsInfo.analyze(analyzer);
- } else if (parseNode instanceof Expr) {
+ importColumnsStmt = (ImportColumnsStmt) parseNode;
Review comment:
why don't you analyze `importColumnStmt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
