EmmyMiao87 commented on a change in pull request #754: Add persist operations 
for routine load job
URL: https://github.com/apache/incubator-doris/pull/754#discussion_r265539967
 
 

 ##########
 File path: 
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
 ##########
 @@ -108,63 +118,72 @@
         NEED_SCHEDULE,
         RUNNING,
         PAUSED,
-        STOPPED,
-        CANCELLED;
+        STOPPED, CANCELLED;
 
         public boolean isFinalState() {
             return this == STOPPED || this == CANCELLED;
         }
-
     }
 
-    protected long id;
     protected String name;
     protected long dbId;
     protected long tableId;
     // this code is used to verify be task request
     protected long authCode;
     protected RoutineLoadDesc routineLoadDesc; // optional
     protected int desireTaskConcurrentNum; // optional
-    protected JobState state;
+    protected JobState state = JobState.NEED_SCHEDULE;
     protected LoadDataSourceType dataSourceType;
     // max number of error data in ten thousand data
     // maxErrorNum / BASE_OF_ERROR_RATE = max error rate of routine load job
     // if current error rate is more then max error rate, the job will be 
paused
     protected int maxErrorNum = DEFAULT_MAX_ERROR_NUM; // optional
-    // thrift object
-    protected TResourceInfo resourceInfo;
+    protected int maxBatchIntervalS = DEFAULT_MAX_INTERVAL_SECOND;
+    protected int maxBatchRows = DEFAULT_MAX_BATCH_ROWS;
+    protected int maxBatchSizeBytes = DEFAULT_MAX_BATCH_SIZE;
 
     protected RoutineLoadProgress progress;
     protected String pausedReason;
     protected String cancelReason;
 
     // currentErrorNum and currentTotalNum will be update
     // when currentTotalNum is more then ten thousand or currentErrorNum is 
more then maxErrorNum
-    protected int currentErrorNum;
-    protected int currentTotalNum;
+    protected long currentErrorNum;
 
 Review comment:
   Use int is enough.  It will be reset after more then 10000

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to