kangpinghuang commented on a change in pull request #764: Convert next_row
interface to next_block
URL: https://github.com/apache/incubator-doris/pull/764#discussion_r267607697
##########
File path: be/src/olap/rowset/alpha_rowset_reader.cpp
##########
@@ -201,24 +229,38 @@ OLAPStatus
AlphaRowsetReader::_get_next_row_for_singleton_rowset(RowCursor** row
return OLAP_SUCCESS;
}
-OLAPStatus AlphaRowsetReader::_get_next_row_for_cumulative_rowset(RowCursor**
row) {
- size_t pos = 0;
- if (_row_blocks[pos] == nullptr) {
- return OLAP_ERR_DATA_EOF;
- }
- RowCursor* current_row = _row_cursors[pos];
- OLAPStatus status = OLAP_SUCCESS;
- if (!_row_blocks[pos]->has_remaining()) {
- status = _get_next_block(pos, &_row_blocks[pos]);
- if (status != OLAP_SUCCESS) {
- LOG(WARNING) << "_get_next_block failed, status:" << status;
- return status;
+OLAPStatus AlphaRowsetReader::_next_block_for_column_data(size_t pos,
RowBlock** row_block) {
+ // get next block
Review comment:
I think the read logic of first block can be merged in this function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
