kangpinghuang commented on a change in pull request #764: Convert next_row
interface to next_block
URL: https://github.com/apache/incubator-doris/pull/764#discussion_r268630429
##########
File path: be/src/olap/rowset/alpha_rowset_reader.h
##########
@@ -62,34 +75,45 @@ class AlphaRowsetReader : public RowsetReader {
private:
- OLAPStatus _init_column_datas(RowsetReaderContext* read_context);
-
- OLAPStatus _get_next_row_for_singleton_rowset(RowCursor** row);
+ OLAPStatus _init_merge_ctxs(RowsetReaderContext* read_context);
- OLAPStatus _get_next_row_for_cumulative_rowset(RowCursor** row);
+ OLAPStatus _union_block(RowBlock** block);
+ OLAPStatus _merge_block(RowBlock** block);
+ OLAPStatus _next_row_for_singleton_rowset(RowCursor** row);
+ OLAPStatus _next_block_for_column_data(MergeContext* merge_ctx);
- OLAPStatus _get_next_not_filtered_row(size_t pos, RowCursor** row);
-
- OLAPStatus _get_next_block(size_t pos, RowBlock** row_block);
+ // Doris will split query predicates to several scan keys
+ // This function is used to fetch block when advancing
+ // current scan key to next scan key.
+ OLAPStatus _fetch_first_block(MergeContext* merge_ctx);
private:
- int _num_key_columns;
- int _num_short_key_columns;
int _num_rows_per_row_block;
std::string _rowset_path;
AlphaRowsetMeta* _alpha_rowset_meta;
std::vector<std::shared_ptr<SegmentGroup>> _segment_groups;
- std::vector<std::shared_ptr<ColumnData>> _column_datas;
- std::vector<RowBlock*> _row_blocks;
- std::vector<RowCursor*> _row_cursors;
RowsetSharedPtr _rowset;
+
+
Review comment:
additional empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
