kangpinghuang commented on a change in pull request #764: Convert next_row
interface to next_block
URL: https://github.com/apache/incubator-doris/pull/764#discussion_r267608084
##########
File path: be/src/olap/rowset/alpha_rowset_reader.h
##########
@@ -80,16 +72,32 @@ class AlphaRowsetReader : public RowsetReader {
AlphaRowsetMeta* _alpha_rowset_meta;
std::vector<std::shared_ptr<SegmentGroup>> _segment_groups;
std::vector<std::shared_ptr<ColumnData>> _column_datas;
- std::vector<RowBlock*> _row_blocks;
+
+ // For singleton Rowset, there are several SegmentGroups
+ // Each of SegmentGroups correponds to a row_block upon scan
+ std::vector<RowBlock*> _row_blocks;
+ std::unique_ptr<RowBlock> _read_block;
+ OLAPStatus (AlphaRowsetReader::*_next_block)(RowBlock** block) = nullptr;
+
+ // For singleton Rowset, there are several SegmentGroups
+ // Each of SegmentGroups correponds to a row_cursor
std::vector<RowCursor*> _row_cursors;
+ RowCursor* _dst_cursor;
Review comment:
this cursor should be delete when Desctructor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
