imay commented on a change in pull request #1173: load data from Parquet file
(Issues #911)
URL: https://github.com/apache/incubator-doris/pull/1173#discussion_r285380826
##########
File path:
fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -404,7 +403,7 @@ public boolean checkPathExist(String path, Map<String,
String> properties) {
}
}
- public TBrokerFD openReader(String clientId, String path, long
startOffset, Map<String, String> properties) {
+ public TBrokerOpenReaderResponse openReader(String clientId, String path,
long startOffset, Map<String, String> properties) {
Review comment:
this is a bad modification.
In this class, we can't return a RPC's response. We should handle RPC in RPC
layer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
