imay commented on a change in pull request #1173: load data from Parquet file 
(Issues #911)
URL: https://github.com/apache/incubator-doris/pull/1173#discussion_r285380960
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroup.java
 ##########
 @@ -228,6 +231,8 @@ public void write(DataOutput out) throws IOException {
         Text.writeString(out, valueSeparator);
         // lineDelimiter
         Text.writeString(out, lineDelimiter);
+        // format type
+        Text.writeString(out, fileFormat);
 
 Review comment:
   you can't write this value without change META_VERSION. this can make 
frontend unable to load old image.
   
   Now, we don't persist this value until we have enough meta change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to