imay commented on a change in pull request #1173: load data from Parquet file
(Issues #911)
URL: https://github.com/apache/incubator-doris/pull/1173#discussion_r285381323
##########
File path: be/src/exec/broker_reader.cpp
##########
@@ -43,7 +43,7 @@ BrokerReader::BrokerReader(
_path(path),
_cur_offset(start_offset),
_is_fd_valid(false),
- _eof(false),
+ _file_size(0),
Review comment:
why remove _eof?
I think you'd better not change old code if you have sufficient reason,
because this can make review work hard and easy to lead error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
