kangpinghuang commented on a change in pull request #1200: Merge refactor code
into master
URL: https://github.com/apache/incubator-doris/pull/1200#discussion_r288433748
##########
File path: be/src/agent/agent_server.cpp
##########
@@ -430,10 +416,10 @@ void AgentServer::make_snapshot(TAgentResult&
return_value,
TStatus status;
vector<string> error_msgs;
TStatusCode::type status_code = TStatusCode::OK;
-
+ return_value.__set_snapshot_version(PREFERRED_SNAPSHOT_VERSION);
string snapshot_path;
OLAPStatus make_snapshot_status =
- _exec_env->olap_engine()->make_snapshot(snapshot_request,
&snapshot_path);
+ SnapshotManager::instance()->make_snapshot(snapshot_request,
&snapshot_path);
if (make_snapshot_status != OLAP_SUCCESS) {
status_code = TStatusCode::RUNTIME_ERROR;
OLAP_LOG_WARNING("make_snapshot failed. tablet_id: %ld, schema_hash:
%ld, status: %d",
Review comment:
LOG(WARNING)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
