kangpinghuang commented on a change in pull request #1200: Merge refactor code
into master
URL: https://github.com/apache/incubator-doris/pull/1200#discussion_r288476504
##########
File path: be/src/olap/field.cpp
##########
@@ -28,48 +28,46 @@ using std::string;
namespace doris {
-Field* Field::create(const FieldInfo& field_info) {
- Field* field = new Field(field_info);
+Field* Field::create(const TabletColumn& column) {
+ Field* field = new Field(column);
return field;
}
// 这个函数目前不支持字符串类型
Field* Field::create_by_type(const FieldType& type) {
Field* field = NULL;
Review comment:
```suggestion
Field* field = nullptr;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
