kangpinghuang commented on a change in pull request #1200: Merge refactor code
into master
URL: https://github.com/apache/incubator-doris/pull/1200#discussion_r288466347
##########
File path: be/src/olap/cumulative_compaction.h
##########
@@ -102,21 +103,21 @@ class CumulativeCompaction {
// - 如果不成功，返回相应错误码
OLAPStatus _do_cumulative_compaction();
- // 将合并得到的新cumulative文件载入table
+ // 将合并得到的新cumulative文件载入tablet
//
// 输出参数：
- // - unused_indices: 返回不再使用的delta文件对应的olap index
+ // - unused_rowsets: 返回不再使用的delta文件对应的olap index
//
// 返回值：
// - 如果成功，返回OLAP_SUCCESS
// - 如果不成功，返回相应错误码
- OLAPStatus _update_header(std::vector<SegmentGroup*>* unused_indices);
+ OLAPStatus _update_header(const std::vector<RowsetSharedPtr>&
unused_rowsets);
// 删除不再使用的delta文件
//
// 输入输出参数
- // - unused_indices: 待删除的不再使用的delta文件对应的olap index
- void _delete_unused_delta_files(std::vector<SegmentGroup*>*
unused_indices);
+ // - unused_rowsets: 待删除的不再使用的delta文件对应的olap index
Review comment:
```suggestion
// - unused_rowsets: 待删除的不再使用的rowsets
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
