imay commented on a change in pull request #1489: Remove query status report
from BE when query is cancelled normally
URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304191773
##########
File path: fe/src/main/java/org/apache/doris/qe/Coordinator.java
##########
@@ -647,30 +657,31 @@ public void cancel() {
queryStatus.setStatus(Status.CANCELLED);
}
LOG.warn("cancel execution of query, this is outside invoke");
- cancelInternal();
+ cancelInternal(CancelReason.USER_CANCEL);
} finally {
unlock();
}
}
- private void cancelInternal() {
+ private void cancelInternal(CancelReason cancelReason) {
if (null != receiver) {
receiver.cancel();
}
- cancelRemoteFragmentsAsync();
+ cancelRemoteFragmentsAsync(cancelReason);
if (profileDoneSignal != null) {
// count down to zero to notify all objects waiting for this
profileDoneSignal.countDownToZero();
LOG.info("unfinished instance: {}",
profileDoneSignal.getLeftMarks());
}
}
- private void cancelRemoteFragmentsAsync() {
+ private void cancelRemoteFragmentsAsync(CancelReason cancelReason) {
for (BackendExecState backendExecState : backendExecStates) {
TNetworkAddress address = backendExecState.getBackendAddress();
- LOG.info("cancelRemoteFragments initiated={} done={}
hasCanceled={} ip={} port={} fragment instance id={}",
+ LOG.info("cancelRemoteFragments initiated={} done={}
hasCanceled={} ip={} port={} fragment instance id={}, reason: {}",
Review comment:
I think this log can be debug level
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
