imay commented on a change in pull request #1489: Remove query status report
from BE when query is cancelled normally
URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304189958
##########
File path: gensrc/proto/internal_service.proto
##########
@@ -116,6 +116,12 @@ message PExecPlanFragmentResult {
message PCancelPlanFragmentRequest {
required PUniqueId finst_id = 1;
+ enum CancelReason {
Review comment:
I think it's better to move CancelReason out of
`PCancelPlanFragmentRequest`. Because fragment can be cancelled in other
format. For example when Fragment is timed out, cancel thread will cancel this
instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
