imay commented on a change in pull request #1489: Remove query status report
from BE when query is cancelled normally
URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304191098
##########
File path: be/src/runtime/fragment_mgr.cpp
##########
@@ -209,9 +209,12 @@ Status FragmentExecState::execute() {
return Status::OK();
}
-Status FragmentExecState::cancel() {
+Status FragmentExecState::cancel(const
PCancelPlanFragmentRequest::CancelReason& reason) {
std::lock_guard<std::mutex> l(_status_lock);
RETURN_IF_ERROR(_exec_status);
+ if (reason != PCancelPlanFragmentRequest::INTERNAL_ERROR) {
Review comment:
I think it's better to use equal other than not equal here. Because when we
add more types of error later, we should let it report in default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
