gaodayue commented on a change in pull request #1646: Support page compression
in BetaRowset
URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314299730
##########
File path: be/src/olap/rowset/segment_v2/column_writer.h
##########
@@ -38,6 +39,7 @@ struct ColumnWriterOptions {
CompressionTypePB compression_type = NO_COMPRESSION;
bool need_checksum = false;
size_t data_page_size = 64 * 1024;
+ double min_compress_ratio = 0.9;
Review comment:
the name is confusing because compression ratio is conventionally calculated
as `uncompressed_size / compressed_size`. I think `space saving` is more
appropriate here, see the definition in
https://en.wikipedia.org/wiki/Data_compression_ratio
```suggestion
// store compressed page only when space saving is above the threshold.
// space saving = 1 - compressed_size / uncompressed_size
double compression_min_space_saving = 0.1;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
