gaodayue commented on a change in pull request #1646: Support page compression 
in BetaRowset
URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314565890
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/column_writer.h
 ##########
 @@ -140,8 +142,7 @@ class ColumnWriter {
     rowid_t _next_rowid = 0;
 
     const EncodingInfo* _encoding_info = nullptr;
-    // const CompressionCodec* _codec = nullptr;
-    // TODO(zc): compression type
+    const BlockCompressionCodec* _compress_codec = nullptr;
 
 Review comment:
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to