gaodayue commented on a change in pull request #1646: Support page compression 
in BetaRowset
URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314303135
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/column_writer.h
 ##########
 @@ -38,6 +39,7 @@ struct ColumnWriterOptions {
     CompressionTypePB compression_type = NO_COMPRESSION;
     bool need_checksum = false;
 
 Review comment:
   It's not related to this PR, but I think `need_checksum` should be removed. 
Reader can choose to ignore or verify checksum but writer should always compute 
and store checksum for each page.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to