imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315556290
##########
File path: gensrc/thrift/FrontendService.thrift
##########
@@ -604,6 +604,12 @@ struct TSnapshotLoaderReportRequest {
5: optional i32 total_num
}
+// (start_rowset_id, end_rowset_id) not include start and end
+struct TGetRowsetIdResponse {
+ 1: optional i64 start_rowset_id = -1
+ 2: optional i64 end_rowset_id = -1
Review comment:
I prefer [start, end) with start_id and id_count
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
