imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318546557
##########
File path: fe/src/main/java/org/apache/doris/task/SnapshotTask.java
##########
@@ -79,7 +79,7 @@ public TSnapshotRequest toThrift() {
request.setVersion(version);
request.setVersion_hash(versionHash);
request.setList_files(true);
- request.setPreferred_snapshot_version(2);
+ request.setPreferred_snapshot_version(3);
Review comment:
Can make this a global variable? Its better not to write magic number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
