imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318592537
##########
File path: be/src/olap/rowset/segment_writer.cpp
##########
@@ -213,6 +213,12 @@ OLAPStatus SegmentWriter::finalize(uint32_t*
segment_file_size) {
boost::filesystem::path data_dir_path =
tablet_path.parent_path().parent_path().parent_path().parent_path();
std::string data_dir_string = data_dir_path.string();
DataDir* data_dir = StorageEngine::instance()->get_store(data_dir_string);
+ data_dir->add_pending_ids(ROWSET_ID_PREFIX +
_segment_group->rowset_id().to_string());
+ if (OLAP_SUCCESS != (res = file_handle.open_with_mode(
Review comment:
why we open this file two times?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
