gaodayue commented on a change in pull request #1694: optimize V2
BinaryPlainPage format (#1648)
URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r316999904
##########
File path: be/src/olap/rowset/segment_v2/binary_plain_page.h
##########
@@ -224,8 +214,8 @@ class BinaryPlainPageDecoder : public PageDecoder {
return Slice(&_data[str_offset], len);
}
- // Minimum length of a header.
- static const size_t MIN_HEADER_SIZE = sizeof(uint32_t) * 2;
+ // Mininum length of trailer
+ static const size_t MIN_TRAILER_SIZE = sizeof(uint32_t);
Review comment:
can be removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
