gaodayue commented on a change in pull request #1694: optimize V2
BinaryPlainPage format (#1648)
URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317336084
##########
File path: be/src/olap/rowset/segment_v2/binary_plain_page.h
##########
@@ -80,24 +80,21 @@ class BinaryPlainPageBuilder : public PageBuilder {
Slice finish() override {
_finished = true;
- size_t offsets_pos = _buffer.size();
-
- // Set up the header
- encode_fixed32_le(&_buffer[0], _offsets.size());
- encode_fixed32_le(&_buffer[4], offsets_pos);
+ // Set up trailer
+ size_t new_cap = _buffer.size() + _offsets.size() * sizeof(uint32_t) +
MAX_TRAILER_SIZE;
+ if (new_cap > _buffer.capacity())
+ _buffer.GrowArray(new_cap);
_buffer.append(&_offsets[0], _offsets.size() * sizeof(uint32_t));
Review comment:
Yeah, both `encode_fixed32_le` and `put_fixed32_le` handles byte order
correctly. Here I'm talking about the `_offsets` vector that is copied to
`_buffer` by memcpy, which doesn't handle byte order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
