gaodayue commented on a change in pull request #1694: optimize V2
BinaryPlainPage format (#1648)
URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317456094
##########
File path: be/src/olap/rowset/segment_v2/binary_plain_page.h
##########
@@ -63,9 +63,9 @@ class BinaryPlainPageBuilder : public PageBuilder {
// If the page is full, should stop adding more items.
while (!is_page_full() && i < *count) {
auto src = reinterpret_cast<const Slice*>(vals);
+ _buffer.append(src->data, src->size);
size_t offset = _buffer.size();
_offsets.push_back(offset);
- _buffer.append(src->data, src->size);
Review comment:
`_offsets` record the start offset of each entry, therefore we should first
record offset then append slice data here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
