imay commented on a change in pull request #1610: Add bitmap agg type and udaf
URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317221911
##########
File path: be/src/olap/row_cursor.cpp
##########
@@ -180,7 +180,7 @@ OLAPStatus
RowCursor::allocate_memory_for_string_type(const TabletSchema& schema
for (auto cid : _schema->column_ids()) {
fixed_ptr = _fixed_buf + _schema->column_offset(cid);
FieldType type = schema.column(cid).type();
- if (type == OLAP_FIELD_TYPE_VARCHAR || type == OLAP_FIELD_TYPE_CHAR) {
+ if (type == OLAP_FIELD_TYPE_VARCHAR || type == OLAP_FIELD_TYPE_CHAR ||
type == OLAP_FIELD_TYPE_HLL) {
Review comment:
why not write `variable_ptr = column_schema(cid)->allocate_memory(fixed_ptr
+ 1, variable_ptr);` directly and without type check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
