imay commented on a change in pull request #1610: Add bitmap agg type and udaf
URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317432262
##########
File path: be/src/olap/wrapper_field.cpp
##########
@@ -53,14 +53,17 @@ WrapperField* WrapperField::create(const TabletColumn&
column, uint32_t len) {
}
WrapperField* WrapperField::create_by_type(const FieldType& type) {
- Field* rep = Field::create_by_type(type);
- if (rep == nullptr) {
+ bool is_string_type = (type == OLAP_FIELD_TYPE_CHAR
Review comment:
We have change this function's logic in
6d040a33afa292e2c2e75239d77f82b77fcc3cfa
1. you should add TYPE_BITMAP_UNION as is_string_type
2. you should change `be/src/olap/stream_index_common.cpp`
`ColumnStatistics::init`'s logic
3. this can create wrapper field for string type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
