imay commented on a change in pull request #1610: Add bitmap agg type and udaf
URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317222329
##########
File path: be/src/olap/field.h
##########
@@ -400,6 +400,11 @@ class BitmapAggField: public Field {
_agg_info->init(dst, (const char*)src.cell_ptr(), false, arena);
}
+ char* allocate_memory(Slice* slice, char* variable_ptr) const override {
Review comment:
we can write this like this
char* allocate_memory(char* cell_ptr, char* variable_ptr) const override {
auto slice = (Slice*)cell_ptr;
slice->data = nullptr;
return variable_ptr;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
