gaodayue commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322069777
########## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ########## @@ -137,6 +139,13 @@ Status SegmentWriter::_write_zone_map() { return Status::OK(); } +Status SegmentWriter::_write_bloom_filter() { + for (auto column_writer : _column_writers) { Review comment: the type of `_column_writers` has been changed to `vector<unique_ptr<ColumnWriter>>`, thus need to use `auto&` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org