gaodayue commented on a change in pull request #1738: add bloom filter index
URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322070220
##########
File path: be/src/olap/rowset/segment_v2/column_writer.h
##########
@@ -42,7 +44,13 @@ struct ColumnWriterOptions {
// store compressed page only when space saving is above the threshold.
// space saving = 1 - compressed_size / uncompressed_size
double compression_min_space_saving = 0.1;
+ // for zone map index
bool need_zone_map = false;
+
+ // for bloom filter index
+ bool is_bf_column = false;
+ size_t bloom_filter_block_size = 1024;
+ double fpp = BLOOM_FILTER_DEFAULT_FPP;
Review comment:
```suggestion
double bloom_filter_fpp = BLOOM_FILTER_DEFAULT_FPP;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
