gaodayue commented on a change in pull request #1738: add bloom filter index
URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322077367
##########
File path: gensrc/proto/segment_v2.proto
##########
@@ -145,6 +147,13 @@ message ShortKeyFooterPB {
optional uint32 segment_bytes = 7;
}
+message BloomFilterPageFooterPB {
Review comment:
suggest to add `algorithm` and `hash` to denote the algorithm and hash
function used
- bloom filter has many variants and we may want to use other bloom filter
implementation in the future
- we may want to use other hash function (e.g., xxhash) than murmur3 for
better performance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
