yiguolei commented on a change in pull request #1761: Add multi-path in
RowsetGraph
URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322169212
##########
File path: be/src/olap/snapshot_manager.cpp
##########
@@ -438,14 +422,12 @@ OLAPStatus SnapshotManager::_create_snapshot_files(
new_tablet_meta->delete_alter_task();
if (request.__isset.missing_version) {
- new_tablet_meta->revise_inc_rs_metas(rs_metas);
vector<RowsetMetaSharedPtr> empty_rowsets;
new_tablet_meta->revise_rs_metas(empty_rowsets);
} else {
// If this is a full clone, then should clear inc rowset metas
because
// related files is not created
vector<RowsetMetaSharedPtr> empty_rowsets;
- new_tablet_meta->revise_inc_rs_metas(empty_rowsets);
new_tablet_meta->revise_rs_metas(rs_metas);
Review comment:
revise is not useful any more. should remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
