yiguolei commented on a change in pull request #1761: Add multi-path in
RowsetGraph
URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322533801
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1250,7 +1250,7 @@ OLAPStatus
SchemaChangeHandler::_do_process_alter_tablet_v2(const TAlterTabletRe
rowsets_to_delete.push_back(rowset);
}
}
- new_tablet->modify_rowsets(std::vector<RowsetSharedPtr>(),
rowsets_to_delete);
+ new_tablet->delete_rowsets(rowsets_to_delete);
Review comment:
I think there should be only one method calling delete rowsets. it is
capture unused rowset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
