yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322176368
########## File path: be/src/olap/tablet_meta.cpp ########## @@ -553,33 +523,6 @@ RowsetMetaSharedPtr TabletMeta::acquire_rs_meta_by_version(const Version& versio return rs_meta; } -OLAPStatus TabletMeta::delete_inc_rs_meta_by_version(const Version& version) { - auto it = _inc_rs_metas.begin(); - while (it != _inc_rs_metas.end()) { - if ((*it)->version().first == version.first - && (*it)->version().second == version.second) { - _inc_rs_metas.erase(it); - break; - } else { - it++; - } - } - - return OLAP_SUCCESS; -} - -RowsetMetaSharedPtr TabletMeta::acquire_inc_rs_meta_by_version(const Version& version) const { - RowsetMetaSharedPtr rs_meta = nullptr; Review comment: It is used in incremental clone, if it is removed the clone logic may run to error. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org