05/05/2020 12:45, Wisam Monther: > From: Andrew Rybchenko <arybche...@solarflare.com> > > On 4/30/20 1:33 PM, Wisam Jaddo wrote: > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -1504,6 +1504,11 @@ T: git://dpdk.org/next/dpdk-next-net > >> F: app/test-pmd/ > >> F: doc/guides/testpmd_app_ug/ > >> > >> +Flow performance tool > >> +M: Wisam Jaddo <wis...@mellanox.com> > >> +F: app/test-flow-perf > >> +F: doc/guides/flow-perf.rst > >> + > > > >Shouldn't it be alphabetially sorted? I think by app name. > > It looks no, > Current order: > - Sample_packet_forward > - test-pmd > - comp_perf > - eventdev > - proc-info > > So I'll move the new app to be in the end of the test apps, since it's been > added last, is this ok?
If no alphabetical sorting, there should be a logical one. Having rte_flow perf testing after general ethdev testing (testpmd), like you did, is good in my opinion.
