[PATCH v4 04/20] net/ngbe: fix VF promiscuous and allmulticast

[Zaiyu Wang]

The configuration of allmulti and promiscuous modes conflicts
together. For instance, if we enable promiscuous mode, then enable and
disable allmulti, then the promiscuous mode is wrongly disabled.

To resolve this, the following changes are made:
- do nothing when we set/unset allmulti if promiscuous mode is on
- restore the proper mode (none or allmulti) when we disable
  promiscuous mode

Fixes: 7744e90805b5 ("net/ngbe: add promiscuous and allmulticast ops for VF 
device")
Cc: sta...@dpdk.org

Signed-off-by: Zaiyu Wang <zaiyuw...@trustnetic.com>
---
 drivers/net/ngbe/ngbe_ethdev_vf.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ngbe/ngbe_ethdev_vf.c 
b/drivers/net/ngbe/ngbe_ethdev_vf.c
index 6406df40d0..81511fed8a 100644
--- a/drivers/net/ngbe/ngbe_ethdev_vf.c
+++ b/drivers/net/ngbe/ngbe_ethdev_vf.c
@@ -1196,9 +1196,13 @@ static int
 ngbevf_dev_promiscuous_disable(struct rte_eth_dev *dev)
 {
        struct ngbe_hw *hw = ngbe_dev_hw(dev);
+       int mode = NGBEVF_XCAST_MODE_NONE;
        int ret;
 
-       switch (hw->mac.update_xcast_mode(hw, NGBEVF_XCAST_MODE_NONE)) {
+       if (dev->data->all_multicast)
+               mode = NGBEVF_XCAST_MODE_ALLMULTI;
+
+       switch (hw->mac.update_xcast_mode(hw, mode)) {
        case 0:
                ret = 0;
                break;
@@ -1219,7 +1223,7 @@ ngbevf_dev_allmulticast_enable(struct rte_eth_dev *dev)
        struct ngbe_hw *hw = ngbe_dev_hw(dev);
        int ret;
 
-       if (dev->data->promiscuous == 1)
+       if (dev->data->promiscuous)
                return 0;
 
        switch (hw->mac.update_xcast_mode(hw, NGBEVF_XCAST_MODE_ALLMULTI)) {
@@ -1243,6 +1247,9 @@ ngbevf_dev_allmulticast_disable(struct rte_eth_dev *dev)
        struct ngbe_hw *hw = ngbe_dev_hw(dev);
        int ret;
 
+       if (dev->data->promiscuous)
+               return 0;
+
        switch (hw->mac.update_xcast_mode(hw, NGBEVF_XCAST_MODE_MULTI)) {
        case 0:
                ret = 0;
-- 
2.21.0.windows.1