> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Monday, May 18, 2026 7:39 AM
> To: Zaiyu Wang <[email protected]>; Zaiyu Wang
> <[email protected]>
> Cc: [email protected]; [email protected]; Jiawen Wu <[email protected]>;
> [email protected]; [email protected]; Jiawen Wu <[email protected]>
> Subject: Re: [PATCH v4 04/20] net/ngbe: fix VF promiscuous and allmulticast
>
> On Mon, 11 May 2026 18:35:46 +0800
> Zaiyu Wang <[email protected]> wrote:
>
> > The configuration of allmulti and promiscuous modes conflicts
> > together. For instance, if we enable promiscuous mode, then enable and
> > disable allmulti, then the promiscuous mode is wrongly disabled.
> >
> > To resolve this, the following changes are made:
> > - do nothing when we set/unset allmulti if promiscuous mode is on
> > - restore the proper mode (none or allmulti) when we disable
> > promiscuous mode
> >
> > Fixes: 7744e90805b5 ("net/ngbe: add promiscuous and allmulticast ops
> > for VF device")
> > Cc: [email protected]
> >
> > Signed-off-by: Zaiyu Wang <[email protected]>
> > ---
>
> Worth mentioning, but IMHO this is case of AI being overly pedantic.
> Patch is OK as is.
Thanks.
