RE: [PATCH v4 03/20] net/ngbe: add missing CDR config for YT PHY

[Zaiyu Wang]

> Semi-automated AI review feedback.
Thank you for the review. Based on the feedback, I have made the following 
adjustments:
> 
> # DPDK Patch Review - net/ngbe: add missing CDR config for YT PHY
> ## WARNINGS
> 
> ### 1. Missing error checks on PHY register writes
No code change.
In the long-term operation of the Wangxun Emerald Gigabit Ethernet controllers 
supported
by the ngbe driver, PHY register read/write failures are virtually never 
observed.
Consequently, ngbe_write_phy_reg_sds_ext_yt() effectively always returns 0.
We currently have no plan to add return value checks for PHY register access 
routines, and
we believe the existing approach is sufficiently robust in practice.
> ---
> 
> ## INFO
> 
> ### 1. Magic numbers in PHY register writes
No code change.
These values were provided by the PHY vendor (Motorcomm) and the bit 
definitions are not
documented in publicly available register description. 
Replacing them with macros such as YT_CONFIG_REG_XXX would merely introduce 
meaningless
names without improving understandability. Therefore we prefer to keep the raw 
vendor
values as they are.