----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31160/#review72989 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java <https://reviews.apache.org/r/31160/#comment119152> This operation was previously done before adding the casts. Doing it after the cast seems fine from functional perspective; however if we are joining say Int to Bigint and the Int happens to be the build side, we will now create a bigint vector, so it will increase the memory footprint. It's probably worth noting this in the comments for future reference. One could argue that if the build and probe were reversed, we would have created the bigint vector anyways. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java <https://reviews.apache.org/r/31160/#comment119116> Since this method is being used by both HJ and MJ, we should change the error message to something more general: Join conditions cannot be compared; left expression: , right expression: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java <https://reviews.apache.org/r/31160/#comment119161> It seems like it would be useful to keep this check such that we don't materialize either left or right side if the right side returns NONE. - Aman Sinha On Feb. 18, 2015, 7:21 p.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31160/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 7:21 p.m.) > > > Review request for drill and Aman Sinha. > > > Repository: drill-git > > > Description > ------- > > If the return type of the two expressions in the join condition are of > different types then we need to inject a cast on one of the sides for > comparison functions to work as expected > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java > ea19645 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java > 04f3bbe > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java > 257b93e > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > 9d3b8dc > exec/java-exec/src/test/resources/parquetinput/department_decimal.parquet > PRE-CREATION > exec/java-exec/src/test/resources/parquetinput/employee_decimal.parquet > PRE-CREATION > > Diff: https://reviews.apache.org/r/31160/diff/ > > > Testing > ------- > > Added unit tests with hash join and merge join > > > Thanks, > > Mehant Baid > >
