----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31160/#review73073 -----------------------------------------------------------
Ship it! Ship It! - Aman Sinha On Feb. 19, 2015, 2:23 a.m., Mehant Baid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31160/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 2:23 a.m.) > > > Review request for drill and Aman Sinha. > > > Repository: drill-git > > > Description > ------- > > If the return type of the two expressions in the join condition are of > different types then we need to inject a cast on one of the sides for > comparison functions to work as expected > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java > ea19645 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java > 04f3bbe > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java > 257b93e > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java > 55fb59f > exec/java-exec/src/test/resources/parquetinput/department_decimal.parquet > PRE-CREATION > exec/java-exec/src/test/resources/parquetinput/employee_decimal.parquet > PRE-CREATION > > Diff: https://reviews.apache.org/r/31160/diff/ > > > Testing > ------- > > Added unit tests with hash join and merge join > > > Thanks, > > Mehant Baid > >
