----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31160/ -----------------------------------------------------------
(Updated April 3, 2015, 8:13 a.m.) Review request for drill and Aman Sinha. Changes ------- Updated patch to address review comment from Aman to not use hashing as double for aggregates and only to use it for joins and distribution. Repository: drill-git Description ------- If the return type of the two expressions in the join condition are of different types then we need to inject a cast on one of the sides for comparison functions to work as expected Diffs (updated) ----- exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Hash64AsDouble.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Hash64Functions.java 57154ed exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Hash64FunctionsWithSeed.java b9ec956 exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/Hash64WithSeedAsDouble.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java 84a2956 exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PrelUtil.java f7c144f exec/java-exec/src/main/java/org/apache/drill/exec/resolver/TypeCastRules.java d8652f2 exec/java-exec/src/test/java/org/apache/drill/TestFunctionsQuery.java f1005ab Diff: https://reviews.apache.org/r/31160/diff/ Testing ------- Added unit tests with hash join and merge join Thanks, Mehant Baid
