----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32083/ -----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra. Repository: drill-git Description ------- Added null checks to ResultSet.getTYPE(...) methods to return dummy values for SQL NULL (e.g., 0 for getInt(...), Java null for getString()). (Avoids accessing underlying accessors when they have NULL values--possible now that those accessors's isNull methods are not longer hard-coded (generated) to just return false (with DRILL-2136 patch).) Diffs ----- exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java cf5829a Diff: https://reviews.apache.org/r/32083/diff/ Testing ------- Ran new tests for JDBC metadata fixes (DRILL-2420--related) and existing tests. Thanks, Daniel Barclay
