----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32083/ -----------------------------------------------------------
(Updated March 23, 2015, 8:21 p.m.) Review request for drill, Mehant Baid and Parth Chandra. Repository: drill-git Description ------- Added null checks to ResultSet.getTYPE(...) methods to return dummy values for SQL NULL (e.g., 0 for getInt(...), Java null for getString()). Diffs (updated) ----- exec/java-exec/src/main/codegen/config.fmpp 5dc7360 exec/java-exec/src/main/codegen/templates/SqlAccessors.java 3039e5c exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java 7e8da2c exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java b69ae54 exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java 3702257 exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2463GetNullsFailedWithAssertionsBugTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32083/diff/ Testing ------- Ran new tests for JDBC metadata fixes (DRILL-2420--related) and existing tests. Thanks, Daniel Barclay
